♻️ Refactor Focus Manager Event Handling for Enhanced User Experience ✨

[sanjaiyan-dev]

As you can see, the focus manager currently listens to both visibilitychange and focus events by default.

I believe it may be beneficial to consider discontinuing the listening to focus events and solely rely on visibilitychange events.

My rationale behind this proposal is that we might be supporting both events primarily for historical reasons. It is worth noting that visibilitychange was not fully supported in older browsers that are no longer relevant (e.g., IE11).

The focus event has proven to have various pitfalls, as it can be triggered in the following scenarios:

1. Navigating between the application and DevTools.
2. Closing an alert or confirm dialog.
3. Interacting with a file upload dialog.
4. Interacting with an iframe.

These scenarios have the potential to result in a suboptimal user experience.

This pull request is inspired by this reference PR.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 17d1760:

Sandbox	Source
SWR-Basic	Configuration
SWR-States	Configuration
SWR-Infinite	Configuration
SWR-SSR	Configuration

[shuding]

Like it, although there're some tests that we need to update.

[sanjaiyan-dev]

Like it, although there're some tests that we need to update.

Ok, sure! But could you please guide me through it? I apologize for any inconvenience caused.

[promer94]

Most of tests are based on focus event and fireEvent.focus. I guess you need to replace the focus event with visibilitychange event like what @tanstack/query did

[sanjaiyan-dev]

Most of tests are based on focus event and fireEvent.focus. I guess you need to replace the focus event with visibilitychange event like what @tanstack/query did

Okay :)

[sanjaiyan-dev]

Hi (@promer94 , @shuding ),

I apologize for the inconvenience, but I'm having trouble updating the test code correctly. I'm not familiar with the process, and I don't want to risk introducing errors or breaking anything. Could someone please lend me a hand and guide me through the correct steps? I'm sorry for any delays this may cause, and I truly appreciate your assistance.

[promer94]

https://github.com/TanStack/query/pull/4805/files#diff-3cd8cae55f836a38ea976d6cbf9f1b59e8fdfa4d3218b123cb1f9dccfc6824d2
I am sure what blocks you but i think this diff clearly shows what you need to do here.

[shuding]

Changes look good to me but this might need to be landed in v3 as it's breaking.

[sanjaiyan-dev]

Changes look good to me but this might need to be landed in v3 as it's breaking.

Okay 🙌

And thanks a lot @promer94

[koba04]

After this change has landed, we should change the example (Revalidate on Focus) in the docs because some behaviors in the example depend on the focus event.
https://swr.vercel.app/docs/revalidation#revalidate-on-focus

I feel revalidateOnVisible is a more appropriate name for this.

[orca-security-us]

Orca Security Scan Summary

Status	Check	Issues by priority
Passed	Secrets	0   0   0   0	View in Orca

[AhmedBaset]

Changes look good to me but this might need to be landed in v3 as it's breaking.

Any updates on how close is the v3? Can we have like future flags or a canary channel?