Add `src` directory support #8735

ijjk · 2019-09-13T19:29:25Z

This implements the proposed support for locating pages inside of a src directory from the src directory RFC

Closes: #8451

ijjk · 2019-09-13T19:35:45Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/src-support	Change
buildDuration	17.6s	16.5s	-1.2s
nodeModulesSize	42.4 MB	42.4 MB	-80 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.66 kB	6.66 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..1c5d17695.js	43.1 kB	43.1 kB	✓
de003c3a9d30..7695.js gzip	15.4 kB	15.4 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.4 kB	6.4 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..5f.module.js	45.5 kB	45.5 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.11 kB	8.11 kB	✓
link.js gzip	3.48 kB	3.48 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.5 kB	8.5 kB	✓
link.module.js gzip	3.66 kB	3.66 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/src-support	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	946 B	946 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	954 B	954 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	942 B	942 B	✓
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/src-support	Change
buildDuration	17.1s	17.4s	⚠️ +221ms
nodeModulesSize	42.4 MB	42.4 MB	-80 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.66 kB	6.66 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..1c5d17695.js	43.1 kB	43.1 kB	✓
de003c3a9d30..7695.js gzip	15.4 kB	15.4 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.module.js	16.6 kB	16.6 kB	✓
main-HASH.module.js gzip	6.4 kB	6.4 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..5f.module.js	45.5 kB	45.5 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.11 kB	8.11 kB	✓
link.js gzip	3.48 kB	3.48 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.5 kB	8.5 kB	✓
link.module.js gzip	3.66 kB	3.66 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_error.js	248 kB	248 kB	✓
_error.js gzip	66.2 kB	66.2 kB	✓
hooks.html	3.73 kB	3.73 kB	✓
hooks.html gzip	972 B	972 B	✓
index.js	248 kB	248 kB	✓
index.js gzip	66.5 kB	66.5 kB	✓
link.js	255 kB	255 kB	✓
link.js gzip	68.5 kB	68.5 kB	✓
routerDirect.js	249 kB	249 kB	✓
routerDirect.js gzip	66.5 kB	66.5 kB	✓
withRouter.js	249 kB	249 kB	✓
withRouter.js gzip	66.6 kB	66.6 kB	✓
Overall change	1.25 MB	1.25 MB	✓

Commit: 6f542c9

ijjk · 2019-09-17T04:19:23Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/src-support	Change
buildDuration	15.8s	15.4s	-403ms
nodeModulesSize	42 MB	42 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3fa59b1f5.js	43.1 kB	43.1 kB	✓
de003c3a9d30..b1f5.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.module.js	16.5 kB	16.5 kB	✓
main-HASH.module.js gzip	6.39 kB	6.39 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..4b.module.js	45.5 kB	45.5 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/src-support	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	947 B	947 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	955 B	955 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	943 B	943 B	✓
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/src-support	Change
buildDuration	16.2s	16.1s	-119ms
nodeModulesSize	42 MB	42 MB	⚠️ +180 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.js	18.2 kB	18.2 kB	✓
main-HASH.js gzip	6.65 kB	6.65 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..3fa59b1f5.js	43.1 kB	43.1 kB	✓
de003c3a9d30..b1f5.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.module.js	16.5 kB	16.5 kB	✓
main-HASH.module.js gzip	6.39 kB	6.39 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..4b.module.js	45.5 kB	45.5 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_error.js	248 kB	248 kB	✓
_error.js gzip	66.3 kB	66.3 kB	✓
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	980 B	980 B	✓
index.js	248 kB	248 kB	✓
index.js gzip	66.6 kB	66.6 kB	✓
link.js	256 kB	256 kB	✓
link.js gzip	68.6 kB	68.6 kB	✓
routerDirect.js	249 kB	249 kB	✓
routerDirect.js gzip	66.6 kB	66.6 kB	✓
withRouter.js	249 kB	249 kB	✓
withRouter.js gzip	66.7 kB	66.7 kB	✓
Overall change	1.25 MB	1.25 MB	✓

Commit: 27ff0ed

gautamsi · 2019-09-18T19:37:45Z

#8451 (comment), adding check for renderer/pages is also going to help in the config of now-desktop

packages/next/lib/find-pages-dir.ts

# Conflicts: # packages/next/next-server/server/next-server.ts

…c-support

ijjk · 2019-09-24T14:43:51Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/src-support	Change
buildDuration	17.3s	18.4s	⚠️ +1.1s
nodeModulesSize	48.2 MB	48.2 MB	⚠️ +273 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.js	18.3 kB	18.3 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..2ca0edb75.js	43.2 kB	43.2 kB	✓
de003c3a9d30..db75.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.module.js	16.5 kB	16.5 kB	✓
main-HASH.module.js gzip	6.39 kB	6.39 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..c0.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Rendered Page Sizes

	zeit/next.js canary	ijjk/next.js add/src-support	Change
index.html	3.62 kB	3.62 kB	✓
index.html gzip	948 B	948 B	✓
link.html	3.66 kB	3.66 kB	✓
link.html gzip	956 B	956 B	✓
withRouter.html	3.67 kB	3.67 kB	✓
withRouter.html gzip	943 B	943 B	✓
Overall change	10.9 kB	10.9 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	zeit/next.js canary	ijjk/next.js add/src-support	Change
buildDuration	17.5s	17.6s	⚠️ +55ms
nodeModulesSize	48.2 MB	48.2 MB	⚠️ +273 B

Client Bundles (main, webpack, commons)

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.js	18.3 kB	18.3 kB	✓
main-HASH.js gzip	6.64 kB	6.64 kB	✓
webpack-HASH.js	1.53 kB	1.53 kB	✓
webpack-HASH.js gzip	746 B	746 B	✓
4952ddcd88e7..2b8407376.js	21.9 kB	21.9 kB	✓
4952ddcd88e7..7376.js gzip	7.81 kB	7.81 kB	✓
de003c3a9d30..2ca0edb75.js	43.2 kB	43.2 kB	✓
de003c3a9d30..db75.js gzip	15.5 kB	15.5 kB	✓
framework.5b..dbaff70d3.js	125 kB	125 kB	✓
framework.5b..70d3.js gzip	39.4 kB	39.4 kB	✓
Overall change	210 kB	210 kB	✓

Client Bundles (main, webpack, commons) Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
main-HASH.module.js	16.5 kB	16.5 kB	✓
main-HASH.module.js gzip	6.39 kB	6.39 kB	✓
webpack-HASH.module.js	1.53 kB	1.53 kB	✓
webpack-HASH..dule.js gzip	746 B	746 B	✓
de003c3a9d30..c0.module.js	45.6 kB	45.6 kB	✓
de003c3a9d30..dule.js gzip	16.5 kB	16.5 kB	✓
framework.5b..d3.module.js	125 kB	125 kB	✓
framework.5b..dule.js gzip	39.4 kB	39.4 kB	✓
Overall change	189 kB	189 kB	✓

Client Pages

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.js	1.81 kB	1.81 kB	✓
_app.js gzip	873 B	873 B	✓
_error.js	12 kB	12 kB	✓
_error.js gzip	4.73 kB	4.73 kB	✓
hooks.js	12.7 kB	12.7 kB	✓
hooks.js gzip	4.79 kB	4.79 kB	✓
index.js	318 B	318 B	✓
index.js gzip	222 B	222 B	✓
link.js	8.14 kB	8.14 kB	✓
link.js gzip	3.5 kB	3.5 kB	✓
routerDirect.js	408 B	408 B	✓
routerDirect.js gzip	281 B	281 B	✓
withRouter.js	419 B	419 B	✓
withRouter.js gzip	280 B	280 B	✓
Overall change	35.8 kB	35.8 kB	✓

Client Pages Modern

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_app.module.js	1.7 kB	1.7 kB	✓
_app.module.js gzip	832 B	832 B	✓
_error.module.js	23.3 kB	23.3 kB	✓
_error.module.js gzip	8.59 kB	8.59 kB	✓
hooks.module.js	1.52 kB	1.52 kB	✓
hooks.module.js gzip	793 B	793 B	✓
index.module.js	294 B	294 B	✓
index.module.js gzip	223 B	223 B	✓
link.module.js	8.53 kB	8.53 kB	✓
link.module.js gzip	3.68 kB	3.68 kB	✓
routerDirect.module.js	394 B	394 B	✓
routerDirect..dule.js gzip	281 B	281 B	✓
withRouter.module.js	404 B	404 B	✓
withRouter.m..dule.js gzip	278 B	278 B	✓
Overall change	36.1 kB	36.1 kB	✓

Client Build Manifests

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_buildManifest.js	81 B	81 B	✓
_buildManifest.js gzip	61 B	61 B	✓
_buildManifest.module.js	81 B	81 B	✓
_buildManife..dule.js gzip	61 B	61 B	✓
Overall change	162 B	162 B	✓

Serverless bundles Overall decrease ✓

	zeit/next.js canary	ijjk/next.js add/src-support	Change
_error.js	251 kB	251 kB	-141 B
_error.js gzip	67.2 kB	67.2 kB	-26 B
hooks.html	3.75 kB	3.75 kB	✓
hooks.html gzip	981 B	981 B	✓
index.js	252 kB	252 kB	-141 B
index.js gzip	67.5 kB	67.5 kB	-38 B
link.js	259 kB	259 kB	-141 B
link.js gzip	69.6 kB	69.5 kB	-33 B
routerDirect.js	253 kB	252 kB	-141 B
routerDirect.js gzip	67.6 kB	67.5 kB	-37 B
withRouter.js	252 kB	252 kB	-141 B
withRouter.js gzip	67.7 kB	67.6 kB	-38 B
Overall change	1.27 MB	1.27 MB	-705 B

Commit: 07fa907

ijjk added 3 commits September 13, 2019 00:32

Add find-pages-dir

1e50d8d

Merge remote-tracking branch 'upstream/canary' into add/src-support

075ebe1

Add support for src directory

6f542c9

ijjk requested review from lfades, Timer and timneutkens as code owners September 13, 2019 19:29

ijjk added the Type: Enhancement label Sep 13, 2019

ijjk added this to the 9.0.7 milestone Sep 13, 2019

Merge remote-tracking branch 'upstream/canary' into add/src-support

27ff0ed

kachkaev mentioned this pull request Sep 17, 2019

[RFC] src directory #8451

Closed

Add test for pages dir preference

3b9f3b1

gautamsi reviewed Sep 24, 2019

View reviewed changes

packages/next/lib/find-pages-dir.ts Outdated Show resolved Hide resolved

ijjk added 3 commits September 24, 2019 09:36

Merge remote-tracking branch 'upstream/canary' into add/src-support

831333e

# Conflicts: # packages/next/next-server/server/next-server.ts

Update comment

d086753

Merge branch 'add/src-support' of github.com:ijjk/next.js into add/sr…

07fa907

…c-support

timneutkens approved these changes Sep 24, 2019

View reviewed changes

timneutkens merged commit a8e3b02 into vercel:canary Sep 24, 2019

Timer deleted the add/src-support branch September 24, 2019 15:40

Timer modified the milestones: 9.0.7, 9.1.0 Oct 7, 2019

vercel locked as resolved and limited conversation to collaborators Feb 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `src` directory support #8735

Add `src` directory support #8735

ijjk commented Sep 13, 2019

ijjk commented Sep 13, 2019

ijjk commented Sep 17, 2019

gautamsi commented Sep 18, 2019

ijjk commented Sep 24, 2019

Add src directory support #8735

Add src directory support #8735

Conversation

ijjk commented Sep 13, 2019

ijjk commented Sep 13, 2019

Stats from current PR

ijjk commented Sep 17, 2019

Stats from current PR

gautamsi commented Sep 18, 2019

ijjk commented Sep 24, 2019

Stats from current PR

Add `src` directory support #8735

Add `src` directory support #8735