Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop hardcoding require('next/dist/compiled/react') #65122

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

Stop hardcoding require('next/dist/compiled/react') #65122

wants to merge 1 commit into from

Commits on Apr 27, 2024

  1. Stop hardcoding require('next/dist/compiled/react')` 

    This will be picked up by our `next` alias in `createWebpackAliases`.
Any subsequent alias of `next/*` would be ignored e.g. aliasing `next/dist/compiled/react` to the react-server entrypoint.

I also hope we don't actually need this since we're already aliasing `react` to `next/dist/compiled/react` in Webpack.
At the same time we're not hardcoding `next/dist/compiled/react-dom`.
This split in behavior is really confusing.

The alternate would be ensuring that our `next` alias becomes a falback.
Or list all the public entrypoints.
Or remove it entirely.
    @eps1lon
    eps1lon committed Apr 27, 2024
    Configuration menu
    Copy the full SHA
    4d78689 View commit details
    Browse the repository at this point in the history