add CI script for benchmarks #64718
Open
add CI script for benchmarks #64718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arlyon
requested review from
jh3y and
timeyoutakeit
and removed request for
a team
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
arlyon
force-pushed
the
arlyon/memory-benchmark-collect-data
branch
from
d7ccbe0
to
73c3137
Compare
arlyon
requested review from
timneutkens,
ijjk,
shuding,
huozhi and
a team
as code owners
arlyon
force-pushed
the
arlyon/memory-benchmark-ci-2
branch
from
745d903
to
0a47009
Compare
arlyon
force-pushed
the
arlyon/memory-benchmark-collect-data
branch
from
73c3137
to
3a62b46
Compare
arlyon
force-pushed
the
arlyon/memory-benchmark-ci-2
branch
from
0a47009
to
cd39f02
Compare
arlyon
force-pushed
the
arlyon/memory-benchmark-collect-data
branch
from
3a62b46
to
ac414a8
Compare
arlyon
force-pushed
the
arlyon/memory-benchmark-ci-2
branch
from
cd39f02
to
6006cb6
Compare
arlyon
force-pushed
the
arlyon/memory-benchmark-collect-data
branch
from
ac414a8
to
56b80de
Compare
arlyon
force-pushed
the
arlyon/memory-benchmark-ci-2
branch
from
6006cb6
to
567a9a7
Compare
| - name: Build binary | ||
| run: cargo build --profile release-with-debug --manifest-path $GITHUB_WORKSPACE/packages/next-swc/crates/next-build-test/Cargo.toml | ||
| - name: Run benchmark | ||
| run: bash bench.sh 29de71d77fd3db93c33cc3886c64a32ad889278f ${{ matrix.pages }} |
There was a problem hiding this comment.
I don't think the commit should be hard-coded?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
See below for the branches this is based on. This PR adds a run to the CI with manual trigger so that we can collect data on it. Once the other two merge, I will begin testing this PR. Still need to validate that the artifacts upload as expected.
Why?
We want to run some consistent benches on memory usage so we can measure over time.
How?
Closes NEXT-
Fixes #