Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-universal-configuration examples #4519

Closed
wants to merge 0 commits into from
Closed

Update with-universal-configuration examples #4519

wants to merge 0 commits into from

Conversation

davscro
Copy link
Contributor

@davscro davscro commented Jun 1, 2018

resolves #4498

@davscro
Copy link
Contributor Author

davscro commented Jun 19, 2018

hi @timneutkens , what is the status of this pull request? Let me know if I have to adjust something.
Thanks in advance 😉

timneutkens
timneutkens reviewed Jun 19, 2018
View reviewed changes
examples/with-universal-configuration-runtime/pages/index.js Outdated
@@ -1,17 +1,19 @@
import React from 'react'
import env from '../lib/env'
import getConfig from 'next/config'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems like 2 PRs are mixed here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I resolved that, now they are seperated...

@timneutkens
Copy link
Member

Actually, the easiest way to go is doing this:

Change this.props.url here:

https://github.com/zeit/next.js/blob/canary/server/document.js#L99

To:

{(children || []).map((child) => {
  if(child.type === 'title') {
     // implement warning logic here
  }
  return child
})}

@davscro
Copy link
Contributor Author

davscro commented Jun 19, 2018 •
edited

<title> warning PR is here #4596

@davscro davscro closed this Jun 19, 2018
@davscro davscro mentioned this pull request Jun 19, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update with-universal-configuration example
2 participants
@davscro @timneutkens