docs(deployment): prune non-production deps #23056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added the following line, to remove the size of the `runner` (production) image. This will remove the `devDependencies` from the container after `next build` completes. ``` yarn install --production --ignore-scripts --prefer-offline ``` For the typescript starter, this is the change in size | before <br/>proposed change<br/>size in bytes | after <br/> proposed change <br/> size in bytes| |----|---| | 347MB | 176MB |
portenez
requested review from
divmain,
ijjk,
leerob,
lfades,
Timer and
timneutkens
as code owners
leerob
reviewed
Apr 20, 2021
docs/deployment.md
Outdated
| @@ -98,7 +98,8 @@ FROM node:alpine AS builder | |||
| WORKDIR /app | |||
| COPY . . | |||
| COPY --from=deps /app/node_modules ./node_modules | |||
| RUN yarn build | |||
| RUN yarn build \ | |||
| yarn install --production --ignore-scripts --prefer-offline | |||
There was a problem hiding this comment.
Don't we really just need --production here? Why the others? Can we also keep on one line?
There was a problem hiding this comment.
I added the additional flags because I followed the recommendation in this GitHub issue:
yarnpkg/yarn#696 (comment)
Here's the comment for convenience:
yarn install --production is close, but it does a few things prune doesn't. It's a little annoying to have to build native modules twice in a CI pipeline just to prune. You can prevent rebuilding packages that already exist in cache with the --ignore-scripts flag. Additionally, prune doesn't check npm registry, so add --prefer-offline.
So, yarn install --production --ignore-scripts --prefer-offline == npm prune --productio
leerob
approved these changes
Apr 20, 2021
SokratisVidros
pushed a commit
to SokratisVidros/next.js
that referenced
this pull request
Apr 21, 2021
added the following line, to remove the size of the `runner` (production) image. This will remove the `devDependencies` from the container after `next build` completes. ``` yarn install --production --ignore-scripts --prefer-offline ``` For the typescript starter, this is the change in size | before <br/>proposed change<br/>size in bytes | after <br/> proposed change <br/> size in bytes| |----|---| | 347MB | 176MB |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the following line, to remove the size of the
runner(production) image. This will remove thedevDependenciesfrom the container afternext buildcompletes.For the typescript starter, this is the change in size
proposed change
size in bytes
proposed change
size in bytes