Skip to content

Commit

Permalink
Fix multi-zone test by removing dependency list (#65589)
Browse files Browse the repository at this point in the history
This test was failing with my changes in
#64932 because it was using the
new Next.js changes, but not the corresponding react-dom changes.

An alternative solution would be to update the react-dom versions to
match those in the rest of the project (19 beta), but I think this is
better overall.

After removing the dependencies, this test works in my branch.
  • Loading branch information
Ethan-Arrowood committed May 10, 2024
1 parent 8c5add2 commit 6487873
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions test/e2e/multi-zone/app/package.json
@@ -1,12 +1,5 @@
{
"name": "with-zones",
"version": "1.0.0",
"private": true,
"dependencies": {
"@types/react": "18.0.28",
"next": "canary",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"typescript": "^4.9.3"
}
"private": true
}

0 comments on commit 6487873

Please sign in to comment.