Skip to content

Commit

Permalink
Stop hardcoding require('next/dist/compiled/react')`
Browse files Browse the repository at this point in the history
This will be picked up by our `next` alias in `createWebpackAliases`.
Any subsequent alias of `next/*` would be ignored e.g. aliasing `next/dist/compiled/react` to the react-server entrypoint.

I also hope we don't actually need this since we're already aliasing `react` to `next/dist/compiled/react` in Webpack.
At the same time we're not hardcoding `next/dist/compiled/react-dom`.
This split in behavior is really confusing.

The alternate would be ensuring that our `next` alias becomes a falback.
Or list all the public entrypoints.
Or remove it entirely.
  • Loading branch information
eps1lon committed Apr 27, 2024
1 parent 3050f45 commit 4d78689
Show file tree
Hide file tree
Showing 74 changed files with 81 additions and 107 deletions.
Expand Up @@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
(function() {
'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');

var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';
Expand Down
Expand Up @@ -10,7 +10,7 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');

// Do not require this module directly! Use normal `invariant` calls with
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
(function() {
'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');
var stream = require('stream');

Expand Down
Expand Up @@ -10,7 +10,7 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');
var stream = require('stream');

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
(function() {
'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');

var ReactSharedInternals = React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;

Expand Down
Expand Up @@ -10,7 +10,7 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');

var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
(function() {
'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');

var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';
Expand Down
Expand Up @@ -10,7 +10,7 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');

var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -10,7 +10,7 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');

var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';
Expand Down
Expand Up @@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
(function() {
'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');

var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';
Expand Down
Expand Up @@ -10,7 +10,7 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');

var ReactVersion = '18.3.0-experimental-c3048aab4-20240326';
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -14,7 +14,7 @@ if (process.env.NODE_ENV !== "production") {
(function() {
'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var util = require('util');
var crypto = require('crypto');
var async_hooks = require('async_hooks');
Expand Down
Expand Up @@ -13,7 +13,7 @@
var util = require('util');
var crypto = require('crypto');
var async_hooks = require('async_hooks');
var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');
var stream = require('stream');

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -10,7 +10,7 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var React = require('react');
var ReactDOM = require('react-dom');

/**
Expand Down
Expand Up @@ -14,8 +14,8 @@ if (process.env.NODE_ENV !== "production") {
(function() {
'use strict';

var React = require("next/dist/compiled/react-experimental");
var Scheduler = require("next/dist/compiled/scheduler-experimental");
var React = require('react');
var Scheduler = require('scheduler');

var ReactSharedInternals = React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;

Expand Down
Expand Up @@ -10,8 +10,8 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var Scheduler = require("next/dist/compiled/scheduler-experimental");
var React = require('react');
var Scheduler = require('scheduler');

function noop$3() {}

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Expand Up @@ -23,8 +23,8 @@ if (
) {
__REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStart(new Error());
}
var React = require("next/dist/compiled/react-experimental");
var Scheduler = require("next/dist/compiled/scheduler-experimental");
var React = require('react');
var Scheduler = require('scheduler');

var ReactSharedInternals = React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;

Expand Down
Expand Up @@ -10,8 +10,8 @@

'use strict';

var React = require("next/dist/compiled/react-experimental");
var Scheduler = require("next/dist/compiled/scheduler-experimental");
var React = require('react');
var Scheduler = require('scheduler');

function noop$3() {}

Expand Down

0 comments on commit 4d78689

Please sign in to comment.