Skip to content
This repository has been archived by the owner on Jul 6, 2021. It is now read-only.

Minify CSS when mode is production #327

Merged
merged 4 commits into from Nov 7, 2018
Merged

Minify CSS when mode is production #327

merged 4 commits into from Nov 7, 2018

Conversation

pierreneter
Copy link
Contributor

@timneutkens timneutkens merged commit dc3b9b7 into vercel:master Nov 7, 2018
@timneutkens
Copy link
Member

Related #294

@timneutkens
Copy link
Member

Thanks for the PR!

@pierreneter pierreneter deleted the minify-css branch November 8, 2018 11:09
@kachkaev
Copy link
Contributor

@timneutkens thanks for merging! When about are you planning to release this patch?

@DominikGuzei
Copy link

@kachkaev i can confirm this PR is included in 1.0.2-canary.2

@Jocodinan
Copy link

Jocodinan commented Feb 17, 2019

Hi, i am trying to minify mi generated CSS in .next/static/css folder in production, but when i do the deploy of my app in Zeit, i am still looking the generated file not minified.

i am using next.js 8.0.1 versión.

Can you guys help me with this please?

@raulmmdev
Copy link

The same problem but with next 7.0.2, i only set this configuration

const withCSS = require('@zeit/next-css')
module.exports = withCSS()

should i set another config for minify or the next-css plugin do it by himself??

@chase
Copy link

chase commented May 20, 2019

The same problem but with next 7.0.2, i only set this configuration

const withCSS = require('@zeit/next-css')
module.exports = withCSS()

should i set another config for minify or the next-css plugin do it by himself??

All the fixes made in the past year have been pushed on the canary channel.

To install the latest version: npm install --save @zeit/next-css@0.2.1-canary.4

@raulmmdev
Copy link

Are you sure that is this version 0.2.1-canary.4 ??

@chase
Copy link

chase commented May 24, 2019

Yes, note the version of the last published package: https://github.com/zeit/next-plugins/blob/master/packages/next-css/package.json

@raulmmdev
Copy link

it works for you ?? i still have the problem

@chase
Copy link

chase commented May 24, 2019

It does. I'll post a simple project later today showing it.

@chase
Copy link

chase commented May 24, 2019

Here is a minimal example with steps to reproduce and check that the CSS is minimized:
https://github.com/chase/next-css-minimization-example

@GabrielDelepine
Copy link

GabrielDelepine commented Dec 24, 2019

From what I understand, I need to use the version 1.0.2-canary.2. The change has not been published yet on a stable version

@pierreneter
Copy link
Contributor Author

Hi @Timer, can you help release a new version, it's been a long time since the plugins have been updated.

@Timer
Copy link
Member

Timer commented Dec 25, 2019

We've discontinued these plugins in favor of official CSS support:
vercel/next.js#8626

@pierreneter
Copy link
Contributor Author

Should we update README.md?

@Timer
Copy link
Member

Timer commented Dec 25, 2019

The new support is currently opt-in, we'll be making it stable soon and will update the READMEs then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants