Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0 - TypeScript, Testing, and Modernization #111

Draft
wants to merge 137 commits into
base: master
Choose a base branch
from

Conversation

Mosnar
Copy link
Collaborator

@Mosnar Mosnar commented Apr 20, 2022

To Do

  • Replace API Gateway with Lambda URLs
  • Update docs
  • Validate use of settings.yml file - is there a better approach? (see notes)
  • Update TLS usage
  • Add error cache TTL

Bugs

  • AVIF generation is too slow
  • Finish testing inputValueProcessor
  • Should requested dimensions greater than hard-limit max be capped or rejected? (Currently rejected)

Notes

  • serverless deprecates the usage of settings.yml, and promotes usage of env files. Would you considering going for the latter option? I can assist maybe if you're ok? (See Modernize serverless-sharp #121)
  • I see there is some Makefile and stuff. But the sharp layer for Lambda doesn't really require any building I think (See Modernize serverless-sharp #121)
  • TLSv1 <-- still uses this protocol. AWS seems to already recommend 'TLSv1.2_2021' (See Modernize serverless-sharp #121)

Done

  • Refactor logging
  • Refactor dataflow to make use of middleware
  • Refactor exception handling
  • Add tests for expected output image sizes (ImageRequest and ImageProcessor)
  • Refactor input value parser
  • Fix Types & add definitions
  • Fix/improve tests
  • Improve linting and code style
  • Update Sharp to 0.31.x
  • Implement bundler for ESM & TS
  • Convert to TypeScript
  • Update Serverless Framework
  • Update Imgix schema
  • Add Dockerfiles for building/updating Sharp

@Mosnar Mosnar changed the title Enhancement/modernize Modernization Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serverless: Deprecation warnings Add AVIF support Support lossless param Size: fit=fillmax
1 participant