Support UI Testing #55
Conversation
This so you can pass a cassette URL to your app in `launchEnvironment` that points to a resource in your UI testing target.
timshadel
force-pushed
the
ui-testing
branch
10 times, most recently
from
9ef6de2
to
dbc2704
Compare
This also catches and fixes the test failure on master involving a file that isn't being created because the directory didn't exist.
|
This would be a great feature to have. |
| @@ -195,6 +197,10 @@ public class Session: NSURLSession { | |||
| } | |||
| } | |||
|
|
|||
| var cassetteName = "cassette" | |||
| if let s = cassetteURL?.lastPathComponent { | |||
| cassetteName = s.substringToIndex(s.endIndex.advancedBy(-5)) | |||
There was a problem hiding this comment.
I think it would be much better to get the length directly instead of guessing it's 5
| @@ -214,9 +220,9 @@ public class Session: NSURLSession { | |||
| if let data = string.dataUsingEncoding(NSUTF8StringEncoding) { | |||
| data.writeToFile(outputPath, atomically: true) | |||
| print("[DVR] Persisted cassette at \(outputPath). Please add this file to your test target") | |||
| } else { | |||
| print("[DVR] Failed to persist cassette.") | |||
There was a problem hiding this comment.
In my PR to convert to Swift, I added a return on 223 instead. Slightly more concise :)
| lazy var testFile: NSURL = { | ||
| return NSBundle(forClass: self.dynamicType).URLForResource("testfile", withExtension: "txt")! | ||
| lazy var testFile: NSURL? = { | ||
| return NSBundle(forClass: self.dynamicType).URLForResource("testfile", withExtension: "txt") |
There was a problem hiding this comment.
👎 In tests, it's better to ! things so you can see the error right away durning the test.
| XCTFail("Error uploading file: \(error)") | ||
| return | ||
| } | ||
| guard let data = data else { XCTFail("Missing request data"); return } |
There was a problem hiding this comment.
👎 No sense in doing this. The test will fail if it's nil anyway.
| @@ -87,6 +96,12 @@ class SessionUploadTests: XCTestCase { | |||
| func writeDataToFile(data: NSData, fileName: String) -> NSURL { | |||
| let documentsPath = NSSearchPathForDirectoriesInDomains(.DocumentDirectory, .UserDomainMask, true)[0] | |||
| let documentsURL = NSURL(fileURLWithPath: documentsPath, isDirectory: true) | |||
|
|
|||
| do { | |||
| try NSFileManager.defaultManager().createDirectoryAtURL(documentsURL, withIntermediateDirectories: true, attributes: nil) | |||
There was a problem hiding this comment.
Actually all the !s were what was keeping you guys from having passing tests on Travis. I had to go through and remove them all to actually see what was truly failing and this piece here was the crux of the fix. The mac tests would pass and the iOS tests would fail because this file was expected but didn't exist. Travis (xcodebuild) only reports:
-[SessionUploadTests testUploadFile]
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
fatal error: unexpectedly found nil while unwrapping an Optional value
Child process terminated with signal 4: Illegal instruction
Test crashed while running.
Since there's no indication of where this crashed, and the test passed in Xcode itself, the actual error took like ½ a day to track down and was super annoying. So, while I like the theory that !s are awesome in testing, this bug totally proves them to still be harmful.
There was a problem hiding this comment.
@soffes Do you want me to put all the !s back anyway?
| class LoginUITests: XCTestCase { | ||
| func testUseValidAuth() { | ||
| let app = XCUIApplication() | ||
| app.launchEnvironment["cassette"] = NSBundle(forClass: LoginUITests.self).URLForResource("valid-auth", withExtension: "json")!.absoluteString |
|
So I'm to the point of wanting to use DVR to stub out network calls for XCTest UI scenarios. Is there more to do with this PR to make it mergeable? Can I help with any of that? Or have there been further developments since this PR opened that would make one able to use DVR with XCTest UI? No pressure, I know OSS is a volunteer effort, just looking to help. |
Add support for easily faking network requests in your app during UI testing.