Notify delegate when task finishes #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a delegate it is common to get the response from the NSURLSessionTask in `URLSession:task:didCompleteWithError:`. However, the response is never set on a SessionDataTask object so we must override it with the interaction response. Unfortunately this means we have to make the `interaction` a property of SessionDataTask which adds state but the `response` is unavailable otherwise.
armstrongnate
changed the title
armstrongnate
changed the title
| @@ -17,6 +17,9 @@ public class Session: NSURLSession { | |||
| private var completedInteractions = [Interaction]() | |||
| private var completionBlock: (Void -> Void)? | |||
|
|
|||
| override public var delegate: NSURLSessionDelegate? { | |||
| return backingSession.delegate | |||
|
This LGTM. 🍏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will need to add full support for the data task delegate eventually but I figured I'd open up a pull request as I add things. If you have any feedback let me know.
I guess this goes along with #11.