Added an exception throw when a ResourceLayout slot is null #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mellinoe
reviewed
Nov 4, 2022
| @@ -8,6 +9,8 @@ internal static class ValidationHelpers | |||
| internal static void ValidateResourceSet(GraphicsDevice gd, ref ResourceSetDescription description) | |||
| { | |||
| #if VALIDATE_USAGE | |||
| if (description.Layout is null) | |||
| throw new NullReferenceException("There is no associated ResourceLayout in the provided ResourceSetDescription"); | |||
There was a problem hiding this comment.
NullReferenceException isn't right here, I would just make this a VeldridException. Veldrid doesn't really throw a large variety of different exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a ResourceLayout array was bound to a Pipeline and, by accident, one of its members remained
null, the CommandList would throw aNullReferenceExceptionthat described very little of the problem and therefore was hard to figure out and debug.This pull request fixes the issue by adding a check through a null-coalescing operator