Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert pointer events to mouseevents #3907

Closed
wants to merge 2 commits into from
Closed

Conversation

lsh
Copy link
Member

@lsh lsh commented Apr 23, 2024

Reverts #3781 in order to mitigate #3893.

lsh added 2 commits April 23, 2024 13:59
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
@lsh lsh requested a review from a team as a code owner April 23, 2024 21:34
@lsh lsh requested a review from domoritz April 23, 2024 21:34
Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should revert everything. Just the change to tooltips is enough.

@lsh
Copy link
Member Author

lsh commented Apr 26, 2024

Closing in favor of #3909

@lsh lsh closed this Apr 26, 2024
@lsh lsh deleted the lsh/revert-mouse-pointer branch April 26, 2024 19:33
lsh pushed a commit that referenced this pull request Apr 26, 2024
Alternative approach to #3907, which selectively reverts only one line
from #3781 in order to mitigate #3893.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants