fix: use domainMin and domainMax to set scale padding
#3906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
Signed-off-by: Lukas Hermann <lukas.hermann@databricks.com>
domoritz
requested changes
Apr 22, 2024
Co-authored-by: Al-Jami Ismail <aljami1379@gmail.com>
lsh
force-pushed
the
lsh/domain-min-max-pad
branch
from
746c78f
to
40212d6
Compare
domoritz
approved these changes
Apr 22, 2024
Merged
lsh
added a commit
that referenced
this pull request
May 10, 2024
**docs** * remove Google Analytics. (via #3894) (Thanks @domoritz!) **monorepo** * switch to ESLint flat config file. (via #3920) (Thanks @lsh!) * update node versions in ci. (via #3915) (Thanks @domoritz!) **vega-encode** * use domainMin and domainMax to set scale padding. (via #3906) (Thanks @Jami159 & @lsh!) **vega-scale** * Add observable10 palette. (via #3843) (Thanks @mcnuttandrew!) * Respect tickMinStep for binned scale. (via #3904) (Thanks @alexxu-db!) **vega-scenegraph** * Revert TooltipHideEvent to MouseOutEvent to fix events on mobile. (via #3909) (Thanks @kadamwhite!) **vega-typings** * Add observable10 palette. (via #3843) (Thanks @mcnuttandrew!) **vega-view** * turn off all handlers in View.finalize() to fix memory leak. (via #3896) (Thanks @cmerrick!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored with @Jami159
Previously, padding was only set if a
domainarray was used, but it didn't usedomainMinordomainMax. Rearranging this code means that the new calculation occurs on the already clamped domain.Editor link