Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make right axis rotate the same way as left #3759

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make right axis rotate the same way as left #3759

wants to merge 2 commits into from

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented May 31, 2023 •
edited

Fix #3571

Before (from online editor):

image

After (from locally linked editor):

image

@kanitw kanitw requested a review from jheer May 31, 2023 11:43
@jheer
Copy link
Member

jheer commented Jun 30, 2023

LGTM, but the test scenes in packages/vega need to be updated to match these changes (see the GENERATE_SCENES flag in packages/vega/test/scene-test.js).

@kanitw kanitw changed the title Make right axis rotate the same way as left fix: make right axis rotate the same way as left Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

@jheer jheer Awaiting requested review from jheer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should right axis title rotate the same way as left axis title by default?
3 participants
@kanitw @jheer @domoritz