Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update touch position on touchmove event #3547

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guersam
Copy link

@guersam guersam commented Jul 25, 2022

Closes #3065

My screencast recorder doesn't show the pointer even if I turned on the setting, but you'll get the idea.

before:
Screencast from 2022년 07월 25일 21시 28분 56초.webm

after:
Screencast from 2022년 07월 25일 21시 27분 05초.webm

@guersam
Copy link
Author

guersam commented Jul 26, 2022

this commit seems to be the cause of #3065.

Before this change, there was only active event reference that is updated along mousemove and touchmove events. This commit separate active and touch, but unlike active, touch is no more updated when handling touchmove event.

Upon reading the history, I think this PR should be enough to fix #3065.

@guersam
Copy link
Author

guersam commented Jul 28, 2022

Just found out it's working only with the canvas renderer. Need to work on svg renderer.

@ObservedObserver
Copy link

Thanks a lot! This fix solved my issue. Hope it can be merged soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

touchmove doesn't update currently picked item
2 participants