Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax constraint(s) to allow valueQuery #445

Merged
merged 1 commit into from
Aug 1, 2018
Merged

Relax constraint(s) to allow valueQuery #445

merged 1 commit into from
Aug 1, 2018

Conversation

ssharif6
Copy link
Contributor

@ssharif6 ssharif6 commented Aug 1, 2018

  • Edit constraints to allow valueQuery and add helper method to distinguish if an encoding was a field or value encoding

  • Configure launch.json for debugging purposes

  • Add debug command to package.json (copied from Vega-Lite)

Working image linked with Dev-version of Voyager (vega/voyager#827)

image

@ssharif6 ssharif6 self-assigned this Aug 1, 2018
@ssharif6 ssharif6 requested a review from kanitw August 1, 2018 08:11
@kanitw kanitw merged commit e0b1994 into master Aug 1, 2018
@kanitw kanitw deleted the ss/query-bug branch August 1, 2018 17:25
@kanitw
Copy link
Member

kanitw commented Aug 1, 2018

Nice. Feel free to make a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants