Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 dev #163

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

V3 dev #163

wants to merge 26 commits into from

Conversation

vdjagilev
Copy link
Owner

No description provided.

vdjagilev and others added 2 commits February 10, 2024 22:40
* feat: ci: update codeql version

* tweak: ci: codeql runs on dev branches

* tweak: ci: remove drafting release on pull req

* tweak: ci: update version of codeql
* Add Excel format support (#156)

* Excel format support added

* fix issuses

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* tweak: ci: fix branch trigger name

* tweak: err check

* chore: refactor writing headers

* chore: minor warning fixes

* chore: ci: update versions

* refactor: split into smaller functions

* tweak: excel: column width

* tweak: excel: cosmetic text wrapping

* tweak: excel: ip-addr & hostname text cosmetic improvements

* tests: implement basic unit tests

* tweak: linter fixes

* tests: increase validation coverage

* tests: coverage: output file

* tests: excel: more test cases

* tests: excel: bigger coverage

---------

Co-authored-by: Gorka <72318822+gorkavp@users.noreply.github.com>
@vdjagilev vdjagilev self-assigned this Feb 23, 2024
formatter/formatter_excel.go Outdated Show resolved Hide resolved
formatter/formatter_excel.go Outdated Show resolved Hide resolved
formatter/formatter_excel.go Show resolved Hide resolved
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 76.36364% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 81.77%. Comparing base (1c26b70) to head (9d995b8).

Current head 9d995b8 differs from pull request most recent head b044932

Please upload reports for the commit b044932 to get more accurate results.

Files Patch % Lines
formatter/formatter_excel.go 73.19% 14 Missing and 12 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
- Coverage   81.79%   81.77%   -0.02%     
==========================================
  Files          20       22       +2     
  Lines         692      801     +109     
==========================================
+ Hits          566      655      +89     
- Misses         79       87       +8     
- Partials       47       59      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vdjagilev vdjagilev marked this pull request as draft February 23, 2024 20:12
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

formatter/formatter_d2.go Show resolved Hide resolved
formatter/formatter_d2.go Show resolved Hide resolved
formatter/formatter_d2.go Outdated Show resolved Hide resolved
formatter/formatter_d2.go Outdated Show resolved Hide resolved
@vdjagilev vdjagilev marked this pull request as ready for review May 22, 2024 20:44
Copy link

codeclimate bot commented May 25, 2024

Code Climate has analyzed commit b044932 and detected 0 issues on this pull request.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant