fix(backups/forkStreamUnpipe): unpause stream after unpipe #7669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeauchamp
force-pushed
the
fix_stream_locked
branch
2 times, most recently
from
0327753
to
0c75b55
Compare
MathieuRA
requested changes
May 23, 2024
julien-f
reviewed
May 31, 2024
| } else { | ||
| // a combination of stream.unpipe, onReadable and onData may stall stream here | ||
| // force it to flow again since we're piping it | ||
| source.resume() |
There was a problem hiding this comment.
Next time we fix something like this we should add a unit test.
julien-f
force-pushed
the
fix_stream_locked
branch
from
d1f8ba2
to
1caf5cc
Compare
when a backup job does delta replication + backup and the replication fails to find the base VM, the backup job does not proceed This commit force the stream to continue to flow after unpiping a descendant stream
julien-f
force-pushed
the
fix_stream_locked
branch
from
1caf5cc
to
b3d63af
Compare
julien-f
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a backup job does delta replication + backup and the replication
fails to find the base VM, the backup job does not proceed
This commit force the stream to continue to flow after unpiping a
descendant stream
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md