Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server): dispose stream properly after v2v import #7655

Merged
merged 2 commits into from
May 31, 2024

Conversation

fbeauchamp
Copy link
Collaborator

Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp force-pushed the fix_dispose_after_v2v branch 2 times, most recently from 295e6c5 to 3efd1fa Compare May 16, 2024 16:03
@fbeauchamp fbeauchamp marked this pull request as ready for review May 21, 2024 08:28
@fbeauchamp fbeauchamp requested a review from b-Nollet May 21, 2024 08:28
Copy link
Contributor

@b-Nollet b-Nollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably notify the bugfix in the changelog

@b-Nollet b-Nollet requested a review from julien-f May 21, 2024 13:58
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No CHANGELOG entries?

@fbeauchamp
Copy link
Collaborator Author

No CHANGELOG entries?
this is not visible by the user. I think there was a forum message pointing to unclosed resource, but I don't find it.
Do you think a changelog entry is needed here ?

@julien-f
Copy link
Member

@fbeauchamp I was thinking about packages to release :)

@julien-f julien-f merged commit 24d584e into master May 31, 2024
1 check failed
@julien-f julien-f deleted the fix_dispose_after_v2v branch May 31, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants