Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(xo-server): improve error handling in v2v #7654

Merged
merged 7 commits into from
May 31, 2024
Merged

feat(xo-server): improve error handling in v2v #7654

merged 7 commits into from
May 31, 2024

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 14, 2024 •
edited

Description

failing import leave some contents une deleted

error message were quite obfuscated : extract a human readable message

image
image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp marked this pull request as ready for review May 21, 2024 07:31
@fbeauchamp fbeauchamp changed the title feat(xo-server): use one defer per Vm import feat(xo-server): improve error handling in v2v May 21, 2024
@fbeauchamp fbeauchamp requested a review from b-Nollet May 21, 2024 08:26
b-Nollet
b-Nollet requested changes May 21, 2024
View reviewed changes
@vates/node-vsphere-soap/lib/client.mjs Outdated Show resolved Hide resolved
@b-Nollet
Copy link
Contributor

And also we should add changelog entry

@fbeauchamp fbeauchamp requested a review from b-Nollet May 27, 2024 08:24
b-Nollet
b-Nollet requested changes May 27, 2024
View reviewed changes
Copy link
Contributor

@b-Nollet b-Nollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maybe notify this improvement in the changelog

@fbeauchamp fbeauchamp requested a review from b-Nollet May 28, 2024 07:21
@b-Nollet b-Nollet requested a review from julien-f May 28, 2024 07:44
julien-f
julien-f approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added @node-vsphere-soap to the list of packages to release and rebased your PR against master.

Please check everything is good and you can merge.

@fbeauchamp fbeauchamp merged commit 53ee698 into master May 31, 2024
1 check failed
@fbeauchamp fbeauchamp deleted the feat_better_error_v2v branch May 31, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-f julien-f julien-f approved these changes

@b-Nollet b-Nollet b-Nollet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fbeauchamp @b-Nollet @julien-f