Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(backups): move metadata to VDI #7648

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor(backups): move metadata to VDI #7648

wants to merge 2 commits into from

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented May 13, 2024 •
edited

Description

Preparing for CBT backup that will only keep a part of the VDI snapshot, and remove the VM

  • extract most of the other_config operation to a file as constants
  • name the constants
  • set the relevant metadata values to the vm AND all its attached VDIs
  • use the VDI as the base to search and update snapshots/replica/backup
  • removed the disableBaseTag option in exportVm

Main vigilance points :

  • please test on your tests backups if delta/full are correctly handled
  • check the otherConfig constant name and propose better name if possible

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp force-pushed the refactor_backup_metadata_to_vdi branch 5 times, most recently from f02ed44 to 9cddc00 Compare June 6, 2024 08:36
@fbeauchamp fbeauchamp marked this pull request as ready for review June 6, 2024 08:41
@fbeauchamp
refactor(backups): stores backup metadata in vdi instead of vm
5ca43f2 
Preparing for CBT backup that will only keep a part of the VDI snapshot, and remove the VM

* extract most of the other_config operation to a file as constants/methods
* name the constants
* set the relevant metadata values to the vm AND all its attached VDIs
* use the VDI as the base to search and update snapshots/replica/backup
@fbeauchamp
changelog
b10a6ac
@fbeauchamp fbeauchamp force-pushed the refactor_backup_metadata_to_vdi branch from 5888307 to b10a6ac Compare June 6, 2024 08:42
@fbeauchamp fbeauchamp requested a review from b-Nollet June 6, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-Nollet b-Nollet Awaiting requested review from b-Nollet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@fbeauchamp