feat(xo-lite): Add collapsible table row for alarm pool #7641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P4l0m4
changed the title
ByScripts
requested changes
May 14, 2024
| @@ -0,0 +1,139 @@ | |||
| <template> | |||
| <tr v-if="isMobile" class="mobile" @click="handleCollapse"> | |||
There was a problem hiding this comment.
You can wrap all tr related to mobile in a <tbody v-if="isMobile">, then all tr related to desktop in a <tbody v-else>
Comment on lines
17
to
19
| <div v-tooltip="new Date(parseDateTime(alarm.timestamp)).toLocaleString()" class="ellipsis time"> | ||
| <RelativeTime :date="alarm.timestamp" /> | ||
| </div> |
There was a problem hiding this comment.
A div can not be a direct child of tr
There was a problem hiding this comment.
As we discussed, this component can be removed.
Comment on lines
81
to
82
| .mobile, | ||
| .desktop { |
There was a problem hiding this comment.
I'd suggest to replace these classes with a alarm-row class on the wrappers.
| </td> | ||
| </tr> | ||
|
|
||
| <tr v-if="!isDescriptionCollapsedRef && isMobile" class="collapsible-description"> |
There was a problem hiding this comment.
This collapsible-description class is not used and can therefore be deleted.
| </tr> | ||
|
|
||
| <tr v-if="!isDescriptionCollapsedRef && isMobile" class="collapsible-description"> | ||
| <td class="collapsible-description__content" colspan="5"> |
There was a problem hiding this comment.
We don't use BEM across the codebase and prefer short, meaningful class names
ByScripts
reviewed
May 14, 2024
@xen-orchestra/lite/src/components/pool/dashboard/ArrowCollapseButton.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: Thierry Goettelmann <thierry@byscripts.info>
Co-authored-by: Thierry Goettelmann <thierry@byscripts.info>
Co-authored-by: Thierry Goettelmann <thierry@byscripts.info>
Co-authored-by: Thierry Goettelmann <thierry@byscripts.info>
…eButton.vue Co-authored-by: Thierry Goettelmann <thierry@byscripts.info>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is a table row with a collapsible description.