Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fs,xo-server): remote encryption algorithm was private #7638

Merged
merged 1 commit into from
May 27, 2024

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented May 6, 2024

Description

Encryption was not showing up in remote page because the remote mixin was using an attribute that was private. See https://help.vates.tech/#ticket/zoom/24076

Introduced by 86ddb8f

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@b-Nollet b-Nollet force-pushed the bugfix-remote-encryption-ui branch from f9687c8 to 7c11914 Compare May 6, 2024 13:51
@b-Nollet b-Nollet changed the title fix(xo-server): restore access to remote encryption algorithm fix(xo-server): remote encryption algorithm was private May 6, 2024
@b-Nollet b-Nollet requested a review from fbeauchamp May 6, 2024 13:53
@fbeauchamp fbeauchamp requested a review from julien-f May 16, 2024 14:43
@fbeauchamp
Copy link
Collaborator

tested on a local remote ✔️

@julien-f julien-f changed the title fix(xo-server): remote encryption algorithm was private fix(fs,xo-server): remote encryption algorithm was private May 22, 2024
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can rebase and merge.

@b-Nollet b-Nollet force-pushed the bugfix-remote-encryption-ui branch from 7c11914 to d10304f Compare May 22, 2024 16:07
@b-Nollet
Copy link
Contributor Author

You can rebase and merge.

I rebased but i don't have the rights to merge.

@julien-f julien-f self-requested a review May 22, 2024 16:40
@julien-f julien-f merged commit 73ea4fa into master May 27, 2024
1 check passed
@julien-f julien-f deleted the bugfix-remote-encryption-ui branch May 27, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants