Parse XML-RPC result of async XAPI tasks #7622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-f
force-pushed
the
xapi-parse-task.result
branch
from
5eb0aae
to
2e3ad96
Compare
julien-f
force-pushed
the
xapi-parse-task.result
branch
3 times, most recently
from
adc15ad
to
cba1831
Compare
MathieuRA
reviewed
May 17, 2024
| @@ -564,10 +563,10 @@ class Vm { | |||
| ) | |||
| } | |||
| try { | |||
| const ref = await this.putResource(stream, '/import/', { | |||
| const [ref] = await this.putResource(stream, '/import/', { | |||
There was a problem hiding this comment.
Why the return of the putResource become an array?
There was a problem hiding this comment.
Because that's the return value of an import.
IIRC, an XVA can contain multiple VMs.
julien-f
force-pushed
the
xapi-parse-task.result
branch
from
cba1831
to
18244d9
Compare
fbeauchamp
approved these changes
May 24, 2024
BREAKING CHANGE Also impacts `getResource()` and `putResource()`.
BREAKING CHANGE It's no longer necessary now that task results are properly parsed.
julien-f
force-pushed
the
xapi-parse-task.result
branch
from
18244d9
to
43fbbb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT SQUASH, review by commit.
Description
Properly parse XML-RPC of async XAPI tasks instead of extracting opaque ref with regexp.
This allows handling more structured results.
Checklist
Fixes #007,See xoa-support#42,See https://...)Introduced byCHANGELOG.unreleased.md