Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2v): choose a better base template #7566

Merged
merged 2 commits into from
May 31, 2024
Merged

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Apr 17, 2024

Description

ask user for the base template to use when importing VM
This is a required field

image

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@fbeauchamp fbeauchamp force-pushed the refacto_esxi_migrate branch 3 times, most recently from a4af6e5 to 6980028 Compare April 17, 2024 13:30
Base automatically changed from refacto_esxi_migrate to master April 17, 2024 13:31
@fbeauchamp fbeauchamp force-pushed the feat_select_template branch 2 times, most recently from 3c024f5 to 548c954 Compare April 29, 2024 16:00
@fbeauchamp fbeauchamp force-pushed the feat_select_template branch 4 times, most recently from 0d46d2c to fbbacd6 Compare May 14, 2024 13:35
@fbeauchamp fbeauchamp marked this pull request as ready for review May 14, 2024 13:35
@fbeauchamp fbeauchamp requested a review from MathieuRA May 14, 2024 13:45
@fbeauchamp
Copy link
Collaborator Author

I will put the changelog after the patch release

@MathieuRA MathieuRA requested a review from julien-f May 14, 2024 15:12
@fbeauchamp fbeauchamp requested a review from MathieuRA May 16, 2024 14:46
@fbeauchamp fbeauchamp force-pushed the feat_select_template branch 2 times, most recently from 99411f2 to f1037f1 Compare May 16, 2024 14:50
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@fbeauchamp fbeauchamp requested a review from MathieuRA May 21, 2024 07:31
@fbeauchamp fbeauchamp force-pushed the feat_select_template branch 2 times, most recently from 213be95 to e27b0eb Compare May 27, 2024 08:26
@julien-f julien-f merged commit 59fbb3e into master May 31, 2024
1 check failed
@julien-f julien-f deleted the feat_select_template branch May 31, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants