-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backup-reports): rewrite with Handlebars #7543
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-Nollet
force-pushed
the
backup-reports-ng
branch
from
May 22, 2024 09:10
df2d61a
to
09b48eb
Compare
pdonias
requested changes
May 28, 2024
b-Nollet
force-pushed
the
backup-reports-ng
branch
2 times, most recently
from
June 3, 2024 14:28
96e250a
to
33cb322
Compare
pdonias
approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please rebase to fix conflicts, test again with latest changes (I haven't tested myself) and if everything is ok, undraft the PR, assign me and I'll merge it.
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
Co-authored-by: Pierre Donias <pierre.donias@gmail.com>
b-Nollet
force-pushed
the
backup-reports-ng
branch
from
June 5, 2024 12:55
33cb322
to
d444f55
Compare
pdonias
approved these changes
Jun 5, 2024
pdonias
changed the title
Backup reports ng
feat(backup-reports): rewrite with Handlebars
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rewriting backup reports with Handlebars.
There are still issues about handlebars blocks not being indented, which make the code less readable, but I did not find any solution to this problem (but it only affect code readability, not the output).
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md