Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backup-reports): rewrite with Handlebars #7543

Merged
merged 16 commits into from
Jun 5, 2024
Merged

Conversation

b-Nollet
Copy link
Contributor

@b-Nollet b-Nollet commented Apr 9, 2024

Description

Rewriting backup reports with Handlebars.

There are still issues about handlebars blocks not being indented, which make the code less readable, but I did not find any solution to this problem (but it only affect code readability, not the output).

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@b-Nollet b-Nollet changed the title WIP rewrite reports with handlebars WIP backup reports ng May 6, 2024
@b-Nollet b-Nollet changed the title WIP backup reports ng Backup reports ng May 27, 2024
@b-Nollet b-Nollet requested a review from pdonias May 27, 2024 08:17
packages/xo-server-backup-reports/src/templates/commons.js Outdated Show resolved Hide resolved
packages/xo-server-backup-reports/src/templates/commons.js Outdated Show resolved Hide resolved
packages/xo-server-backup-reports/src/templates/vm.js Outdated Show resolved Hide resolved
packages/xo-server-backup-reports/src/templates/vm.js Outdated Show resolved Hide resolved
packages/xo-server-backup-reports/src/index.js Outdated Show resolved Hide resolved
packages/xo-server-backup-reports/src/templates/commons.js Outdated Show resolved Hide resolved
packages/xo-server-backup-reports/src/templates/vm.js Outdated Show resolved Hide resolved
@b-Nollet b-Nollet requested a review from pdonias May 29, 2024 06:31
@b-Nollet b-Nollet force-pushed the backup-reports-ng branch 2 times, most recently from 96e250a to 33cb322 Compare June 3, 2024 14:28
Copy link
Member

@pdonias pdonias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please rebase to fix conflicts, test again with latest changes (I haven't tested myself) and if everything is ok, undraft the PR, assign me and I'll merge it.

@b-Nollet b-Nollet marked this pull request as ready for review June 5, 2024 13:27
@b-Nollet b-Nollet requested a review from pdonias June 5, 2024 13:28
@pdonias pdonias changed the title Backup reports ng feat(backup-reports): rewrite with Handlebars Jun 5, 2024
@pdonias pdonias merged commit 3f4ca1b into master Jun 5, 2024
1 check failed
@pdonias pdonias deleted the backup-reports-ng branch June 5, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants