feat(bottom-navigation): add placeholder prop #1618
+49
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@YHoney7 is attempting to deploy a commit to the varletjs Team on Vercel. A member of the Team first needs to authorize it. |
|
还需要修改 types 的 对应文件 |
chouchouji
reviewed
May 11, 2024
|
好的 |
haoziqaq
reviewed
May 11, 2024
chouchouji
reviewed
May 14, 2024
chouchouji
reviewed
May 14, 2024
haoziqaq
reviewed
May 15, 2024
haoziqaq
reviewed
May 16, 2024
| @@ -25,6 +26,8 @@ | |||
| <slot name="fab"></slot> | |||
| </var-button> | |||
| </div> | |||
|
|
|||
| <div v-if="fixed && placeholder" :class="n('--placeholder')" :style="{ height: placeholderHeight }" /> | |||
| import { onSmartMounted } from '@varlet/use' | ||
| import { type BottomNavigationItemProvider } from '../bottom-navigation-item/provide' | ||
|
|
||
| const { name, n, classes } = createNamespace('bottom-navigation') | ||
| const { n: nItem } = createNamespace('bottom-navigation-item') | ||
| const { n: nFab } = createNamespace('bottom-navigation__fab') |
| @@ -81,6 +86,8 @@ export default defineComponent({ | |||
| ) | |||
|
|
|||
| onSmartMounted(() => { | |||
| setPlaceholderHeight() | |||
| @@ -201,6 +201,7 @@ const active = ref(0) | |||
| | `z-index` | Z-index | _number \| string_ | `1` | | |||
| | `active-color` | Color of active tab item | _string_ | `-` | | |||
| | `inactive-color` | Color of inactive tab item | _string_ | `-` | | |||
| | `placeholder` ***3.2.10*** | Whether to generate placeholder elements of the same height at the bottom (`fixed` required) | _boolean_ | `false` | | |||
haoziqaq
reviewed
May 16, 2024
| return | ||
| } | ||
|
|
||
| const bottomRect = getRect(bottomNavigationDom.value!) |
There was a problem hiding this comment.
bottomRect -> bottomNavigationRect
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1618 +/- ##
==========================================
- Coverage 92.84% 92.75% -0.10%
==========================================
Files 306 306
Lines 7172 7193 +21
Branches 1785 1790 +5
==========================================
+ Hits 6659 6672 +13
- Misses 447 454 +7
- Partials 66 67 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
List of tasks you have already done and plan to do.
Change information
Describe your modifications here.
Issues
The issues you want to close, formatted as close #1.
Related Links
Links related to this pr.