Tidy up FluentKit #609
Merged
Tidy up FluentKit #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… useless Swift feature flags
…tions, remove unneeded uses of UnsafeTransfer, use SQLKit's version of SQLQUalifiedTable
…precating the old name.
gwynne
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 24.99% 24.73% -0.26%
==========================================
Files 150 149 -1
Lines 8573 8590 +17
==========================================
- Hits 2143 2125 -18
- Misses 6430 6465 +35
|
0xTim
approved these changes
May 12, 2024
|
SQLite integration tests will pass once vapor/fluent-sqlite-driver#90 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.48.4
A few changes that were missed in previous cleanup and update passes:
asyncversions of someDatabasemethods are now present.SQLDatabasemethods are now correctly forwarded when usingDatabase.logging(to:)..sql(raw:)utility for directly embedding raw SQL into Fluent queries have been renamed to.sql(unsafeRaw:)to better emphasize the inadvisability of their use. The old name still works but is now deprecated.SQLSchemaConverteris now very infinitesimally faster.Sendablewarning workarounds, should slightly improve performance.