Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding China regions #403

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

adding China regions #403

wants to merge 2 commits into from

Conversation

PatMyron
Copy link
Contributor

@PatMyron PatMyron commented Dec 10, 2018

#330

similar to previous #395

git clone https://github.com/patmyron/ec2instances.info
cd ec2instances.info
git remote add upstream https://github.com/powdahound/ec2instances.info
gh pr checkout 403
git fetch upstream
git rebase upstream/master
docker build -t ec2instances.info .
docker run -d --name some-container -p 8080:8080 ec2instances.info
open http://localhost:8080

@cristim
Copy link
Contributor

cristim commented Dec 10, 2018

I'm a bit reluctant to merge this until we have the data available. It will just create confusion for people who expect to see the data but instead won't get anything.

@PatMyron
Copy link
Contributor Author

@cristim agreed

@PatMyron
Copy link
Contributor Author

@cristim #330 (comment)

@PatMyron
Copy link
Contributor Author

cfn-lint started picking up EC2/RDS/DAX instance type information from pricing for AWS China regions this month:
aws-cloudformation/cfn-lint#1635 (comment)
so I think it's worth reconsidering this now

@EverettBerry
Copy link
Contributor

@PatMyron do you happen to know the latest on this? I think it would be cool to add pricing for China and can merge this in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants