Generate shorter folder names in FileUtils::generateUniqueUploadPath #11090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
Status: Stale
|
Still a problem. |
stale
bot
removed
the
Status: Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vanilla/library/Vanilla/FileUtils.php
Line 60 in 7e68d0f
This will create up to 36^12 (4.738.381.338.321.616.896) different folders.
This does not help reduce file system load in any way, it is probably even worse than just dumping every upload in a single folder.
The old implementation creating folders from 0 to 999 is restored with this fix.
See:
3108657#diff-db1553fc5ca69f1a7449390029c1ba07a3eb80beac707e6b13c06098ff424405L281