dockerfile + wrapper script #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacn
commented
Aug 12, 2019
| if use_memcache: | ||
| try: | ||
| from config import memcache_address, memcache_port, invalidation_time | ||
| from .config import memcache_address, memcache_port, invalidation_time |
There was a problem hiding this comment.
just noticed these changes were left in. I cannot remember off the top of my head if they were needed or not. I will test with and without them this evening.
|
Hi, I would be hesitant about merging this until I can have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2
changes
Updates
build_json.pyto take in as a commandline argument the path to write the JSON update file. This is useful for the running the project within a container.Updates
write_to_plex.pyto take in the path to the JSON update file as an argument.Adds
Dockerfilefor building a containerized version of this project.Adds a wrapper script
run-in-docker.pythat wraps building the container from theDockerfileas well as running the two scripts inside the containertesting
I've verified that docker image building and running
build_json.pywork successfully. As I myself do not need this info in the movie descriptions and have a rather large library who's DB I don't have backed up, I did not test outwrite_to_plex.py.todo
However I will look into running a copy of my plex server's DB in a local testing container to test
write_to_plex.pyagainst. This might even be able to be extracted into a generic integration test that the project could run against in Travis or the like.also wanted to say i really like the idea of making this a plex metadata agent but i'd be hesitant investing time and effort into doing so since it seems like plex is phasing out that ability: https://www.reddit.com/r/PleX/comments/9n9qjl/subzero_the_future/ . As niche as it is, jellyfin might be a better target for that effort, though that would require a re-write in a dot Net language or verifying this works under IronPython so who knows.