New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress ASAN errors on tests that intentially crash the server via crash-memcheck-enabled no
#489
Conversation
via `crash-memcheck-enabled no` Signed-off-by: Ping Xie <pingxie@google.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #489 +/- ##
============================================
+ Coverage 68.88% 69.81% +0.92%
============================================
Files 109 109
Lines 61793 61801 +8
============================================
+ Hits 42566 43145 +579
+ Misses 19227 18656 -571 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the failures was exposed by crash-memcheck-enabled
?
i remember if it was exposed by crash-memcheck-enabled
, it will have some FAST MEMORY TEST
log, but in the link, it does not seem to have this log.
This failure occurred in the new test
I still don't know exactly how to interpret every failure reported but there are quite a few references to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other place we call DEBUG SEGFAULT
we also disable this, so we can definitely follow up and try to fix it, but I would like to see if this makes the tests green. They're going to start in an hour, so would rather get this merged and try it out.
…crash-memcheck-enabled no` (valkey-io#489) Fix daily CI run errors like https://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176 Signed-off-by: Ping Xie <pingxie@google.com>
…crash-memcheck-enabled no` (valkey-io#489) Fix daily CI run errors like https://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176 Signed-off-by: Ping Xie <pingxie@google.com> Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
…crash-memcheck-enabled no` (valkey-io#489) Fix daily CI run errors like https://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176 Signed-off-by: Ping Xie <pingxie@google.com> Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
…crash-memcheck-enabled no` (valkey-io#489) Fix daily CI run errors like https://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176 Signed-off-by: Ping Xie <pingxie@google.com>
…crash-memcheck-enabled no` (valkey-io#489) Fix daily CI run errors like https://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176 Signed-off-by: Ping Xie <pingxie@google.com>
…crash-memcheck-enabled no` (valkey-io#489) Fix daily CI run errors like https://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176 Signed-off-by: Ping Xie <pingxie@google.com>
…crash-memcheck-enabled no` (valkey-io#489) Fix daily CI run errors like https://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176 Signed-off-by: Ping Xie <pingxie@google.com> Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
Fix daily CI run errors like https://github.com/valkey-io/valkey/actions/runs/9039450198/job/24842308071#step:6:4176