Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallowing periods in slugs (Response to issue#2383) #2385

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Disallowing periods in slugs (Response to issue#2383) #2385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbf7afb
Update regex pattern to disallow periods in slugs
alinaghale88 Mar 31, 2024
6db8b3b
Update regex in isSlug.js to match all test cases
alinaghale88 Apr 1, 2024
662d79a
Add 'is.not.a.slug' string to invalid slug tests
alinaghale88 Apr 1, 2024
5e19e96
Update regex in isSlug.js & add a valid test case
alinaghale88 Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/isSlug.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import assertString from './util/assertString';

let charsetRegex = /^[^\s-_](?!.*?[-_]{2,})[a-z0-9-\\][^\s]*[^-_\s]$/;
let charsetRegex = /^(?!.*(?:-|_){2,})(?![-_])(?!.*(?:-|_)$)[a-z0-9*&\\]*(?:[-_][a-z0-9*&\\]+)*$/;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something else I noticed, but is there a reason this allows &, * and \ special characters? The original allows \ though I'm not sure why since Slugify ignores \, and @WikiRik mentioned that Slugify is the basis of the regex for isSlug. Slugify also ignores * and replaces & with 'and', so I would consider all of them to be invalid.


export default function isSlug(str) {
assertString(str);
Expand Down
2 changes: 2 additions & 0 deletions test/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12855,6 +12855,7 @@ describe('Validators', () => {
test({
validator: 'isSlug',
valid: [
'f-f',
'foo',
'foo-bar',
'foo_bar',
Expand All @@ -12865,6 +12866,7 @@ describe('Validators', () => {
],
invalid: [
'not-----------slug',
'is.not.a.slug',
'@#_$@',
'-not-slug',
'not-slug-',
Expand Down