Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regex added for Senegal sn-SN #2304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Akilan19
Copy link

@Akilan19 Akilan19 commented Oct 2, 2023

Validations added for Senegal - Issue #1761

  • isMobilePhone regex added for 'sn-SN'. Reference -Telephone_numbers_in_Senegal
  • isPostalCode regex added for 'SN'. Reference
  • Relevant unit test added & Readme updated.

CHECKLIST

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
    image

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b958bd7) 99.95% compared to head (011da84) 99.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         107      107              
  Lines        2454     2449       -5     
  Branches      619      619              
==========================================
- Hits         2453     2448       -5     
  Partials        1        1              
Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)
src/lib/isPostalCode.js 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akilan19 Akilan19 marked this pull request as ready for review October 2, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant