-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Antarctica in country for mobile validation #1761 #2092
Conversation
Added validation for Antarctica validatorjs#1761
Updated readme for Antarctica validatorjs#1761
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2092 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add tests
I didn't look into the RegEx itself yesterday but it seems that the Artic bases do not really have their own phone numbers. Also I would not be sure how often this would be used, so I would recommend against merging this PR |
This my first pr could u please approve |
@Sambhavmahajan11 thank you for the PR, but I also do not see any real value in this PR, as this seems to be too much of a niche use case (if at all). I would too rather see this as a "Won't Do" as well. @profnandaa would you agree to close this issue? |
@pano9000 -- good by me, we can close. |
@Sambhavmahajan11 again, thanks for the PR, but I need to close this PR, kindly see above for the reasons. |
Added Antarctica in country for mobile validation #1761
Also updated the readme
Checklist