Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(test/gurka/) Using C++17 filesystem with few changes #4664

Conversation

cvvergara
Copy link
Contributor

Issue

What issue is this PR targeting? If there is no issue that addresses the problem, please open a corresponding issue and link it here.

Tasklist

  • include "filesystem.h" -> #include <filesystem>
    • filesystem::fn -> std::filesystem::fn
    • On 5 files that do not have warnings
    • Added #include <filesystem> when needed
  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

@cvvergara cvvergara changed the title (test/gurka/) Using C++17 filesystem on 5 files (test/gurka/) Using C++17 filesystem with few changes Mar 27, 2024
@cvvergara cvvergara marked this pull request as draft March 27, 2024 17:41
@cvvergara cvvergara marked this pull request as draft March 27, 2024 17:41
@cvvergara cvvergara marked this pull request as ready for review March 27, 2024 19:51
Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@nilsnolde nilsnolde merged commit 1ae956d into valhalla:master Mar 29, 2024
7 checks passed
@cvvergara cvvergara deleted the remove-filesystem-h-from-test-gurka-simple-removal-1 branch March 30, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants