FIXED Issue #4652: src/thor/unidirectional_astar.cc doesnt work for date_time type 2, i.e. for arrival #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor bugfix for timedep astar
minor bugfix
for the PR guidelines
|
can you run |
Co-authored-by: Kevin Kreiser <kevinkreiser@gmail.com>
kevinkreiser
approved these changes
Mar 24, 2024
|
I'm on a vacation right now and cannot access my work system, editing the code on github, so can't run any scripts. |
|
Yeah I have the exact same fix in #4642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 4652 ([https://github.com//issues/4652])
issue : src/thor/unidirectional_astar.cc doesnt work for date_time type 2, i.e. for arrival
steps to recreate: just make any long route(idk roughly around 1500 kms) with speed_type = 2(arrival), it will say "no route found".
its a minor fix i know but its bugging me.