Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor path pruning for not_thru/destonly/closures #4638

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

refactor path pruning for not_thru/destonly/closures #4638

wants to merge 18 commits into from

Commits on Mar 18, 2024

  1. all refactored (and fixed), but only not_thru is reviewed so far

    @nilsnolde
    nilsnolde committed Mar 18, 2024
    Copy the full SHA
    a369698 View commit details
    Browse the repository at this point in the history

  2. reviewed destonly as well; still no tests

    @nilsnolde
    nilsnolde committed Mar 18, 2024
    Copy the full SHA
    e9a94a1 View commit details
    Browse the repository at this point in the history

  3. small b ug

    @nilsnolde
    nilsnolde committed Mar 18, 2024
    Copy the full SHA
    8b4d88e View commit details
    Browse the repository at this point in the history

  4. some amends

    @nilsnolde
    nilsnolde committed Mar 18, 2024
    Copy the full SHA
    5038dbe View commit details
    Browse the repository at this point in the history

  5. some exes not updated

    @nilsnolde
    nilsnolde committed Mar 18, 2024
    Copy the full SHA
    54f9db4 View commit details
    Browse the repository at this point in the history

  6. fix astar.cc

    @nilsnolde
    nilsnolde committed Mar 18, 2024
    Copy the full SHA
    b8b4b18 View commit details
    Browse the repository at this point in the history

  7. changelog

    @nilsnolde
    nilsnolde committed Mar 18, 2024
    Copy the full SHA
    607d3cd View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. don't change the default

    @nilsnolde
    nilsnolde committed Mar 19, 2024
    Copy the full SHA
    c5749f6 View commit details
    Browse the repository at this point in the history

  2. revert the changes to map matching algos; still doesn't fix the mapma… 

    …tcher test failure
    @nilsnolde
    nilsnolde committed Mar 19, 2024
    Copy the full SHA
    5865eb9 View commit details
    Browse the repository at this point in the history

  3. some fixes

    @nilsnolde
    nilsnolde committed Mar 19, 2024
    Copy the full SHA
    579482f View commit details
    Browse the repository at this point in the history

  4. braces

    @nilsnolde
    nilsnolde committed Mar 19, 2024
    Copy the full SHA
    997a40f View commit details
    Browse the repository at this point in the history

  5. destonly needs to be a separate EdgeLabel property because transition… 

    …_cost relies on it
    @nilsnolde
    nilsnolde committed Mar 19, 2024
    Copy the full SHA
    d990027 View commit details
    Browse the repository at this point in the history

  6. see easier diff

    @nilsnolde
    nilsnolde committed Mar 19, 2024
    Copy the full SHA
    6cd0e92 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. now I see the disadvantage of putting not_thru_pruning on the cost ra… 

    …ther the algorithm, as it's really an algo decision.. needed to alter thor_worker::parse_costing to make this work, which is less than ideal. ultimately I'm ok with the result..
    @nilsnolde
    nilsnolde committed Mar 20, 2024
    Copy the full SHA
    6eba010 View commit details
    Browse the repository at this point in the history

  2. add not_thru_pruning to all other costing models; this fails a condit… 

    …ional_restrictions test which uses unidir a* which previously wasn't respecting not_thru regions and now goes into a second pass where both conditional access restrictions AND not_thru are disabled and finds of course the shorter path right over the restricted edge
    @nilsnolde
    nilsnolde committed Mar 20, 2024
    Copy the full SHA
    9a5be0a View commit details
    Browse the repository at this point in the history

  3. disable not_thru pruning for algos which don't have a second pass

    @nilsnolde
    nilsnolde committed Mar 20, 2024
    Copy the full SHA
    7abd7f3 View commit details
    Browse the repository at this point in the history

  4. disable failing test_route test

    @nilsnolde
    nilsnolde committed Mar 20, 2024
    Copy the full SHA
    689707a View commit details
    Browse the repository at this point in the history

  5. forgot to add back dest_only to default constructor

    @nilsnolde
    nilsnolde committed Mar 20, 2024
    Copy the full SHA
    b71e92b View commit details
    Browse the repository at this point in the history