fixed CostMatrix shapes for routes against trivial oneways #4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsnolde
commented
Mar 15, 2024
Comment on lines
-1247
to
-1248
| auto is_first_edge = path_edge == path_edges.front(); | ||
| auto is_last_edge = path_edge == path_edges.back(); |
There was a problem hiding this comment.
for the case of seemingly trivial routes which go against the oneway, both of these are true and then further down it'd trim the shape according to a trivial route which is not doing the right thing to do. we have to do this index based to really tell if it's the first/last edge.
There was a problem hiding this comment.
yeah these needed to be pointer comparison not equality operator
kevinkreiser
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4538 (comment)