add libgdal to final docker image #4629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -73,7 +73,7 @@ COPY --from=builder /usr/lib/python3/dist-packages/valhalla/* /usr/lib/python3/d | |||
| # install all the posix locales that we support | |||
| RUN export DEBIAN_FRONTEND=noninteractive && apt update && \ | |||
| apt install -y \ | |||
| libcurl4 libczmq4 libluajit-5.1-2 \ | |||
| libcurl4 libczmq4 libluajit-5.1-2 libgdal32 \ | |||
There was a problem hiding this comment.
I would have thought it'd be:
Suggested change
| libcurl4 libczmq4 libluajit-5.1-2 libgdal32 \ | |
| libcurl4 libczmq4 libluajit-5.1-2 libgdal-dev \ |
There was a problem hiding this comment.
or oh I guess it's the runner so only need the lib but why 32? is it a version suffix?
There was a problem hiding this comment.
ok yeah must be the version. unfortunate naming!
There was a problem hiding this comment.
Yeah it’s like “libcurl4”, some (to me) strange sort of .so versioning
kevinkreiser
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the docker build is failing in master when compiling the python bindings. that's pointing to a much bigger problem, where
ENABLE_GDAL=ONwould currently not even be able to runvalhalla_service, becauselibgdal32wasn't installed in the final docker image, just in the building intermediate docker image.