Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBF support for /expansion #4614

Merged
merged 18 commits into from Apr 22, 2024
Merged

PBF support for /expansion #4614

merged 18 commits into from Apr 22, 2024

Conversation

chrstnbwnkl
Copy link
Contributor

@chrstnbwnkl chrstnbwnkl commented Feb 27, 2024 •
edited

Tasklist

  • Add tests
  • Add #fixes with the issue number that this PR addresses
  • Update the docs with any new request parameters or changes to behavior described
  • Update the changelog
  • If you made changes to the lua files, update the taginfo too.

@chrstnbwnkl chrstnbwnkl marked this pull request as ready for review February 27, 2024 15:24
nilsnolde
nilsnolde requested changes Mar 21, 2024
View reviewed changes
Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have absolutely nothing to add here, good job:)

Well, other than extending the expansion test to prove the PBF stuff.

@nilsnolde
Copy link
Member

also don't feel like you'd have to wait for #4601. it's a bit unfortunate, but not a big deal to do it after this PR was merged to master.

@chrstnbwnkl
Copy link
Contributor Author

I thought there was no necessity for new tests since the protobuf representation is used anyway for the default JSON serialization.

@nilsnolde
Copy link
Member

Right, no detailed tests, but there should somewhere be a pbf output test for expansion IMO.

chrstnbwnkl
chrstnbwnkl commented Apr 22, 2024
View reviewed changes
src/thor/expansion_action.cc

using namespace valhalla;

void writeExpansionProgress(Expansion* expansion,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snake_case this

@chrstnbwnkl chrstnbwnkl merged commit c8f4773 into valhalla:master Apr 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsnolde nilsnolde nilsnolde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrstnbwnkl @nilsnolde