remove int backing and sort enums + corresponding match statements

valantic · Mar 27, 2024 · dfcf749 · dfcf749
1 parent 2345607
commit dfcf749
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/Enum/ElementInIndexOperation.php b/src/Enum/ElementInIndexOperation.php
@@ -4,10 +4,10 @@
 
 namespace Valantic\ElasticaBridgeBundle\Enum;
 
-enum ElementInIndexOperation: int
+enum ElementInIndexOperation
 {
-    case NOTHING = 0;
-    case DELETE = 1;
-    case INSERT = 2;
-    case UPDATE = 3;
+    case INSERT;
+    case UPDATE;
+    case DELETE;
+    case NOTHING;
 }
diff --git a/src/Service/PropagateChanges.php b/src/Service/PropagateChanges.php
@@ -102,8 +102,8 @@ private function doHandleIndex(
 
         $operation = match (true) {
             !$isPresent && $shouldIndex => ElementInIndexOperation::INSERT,
-            $isPresent && !$shouldIndex => ElementInIndexOperation::DELETE,
             $isPresent && $shouldIndex => ElementInIndexOperation::UPDATE,
+            $isPresent && !$shouldIndex => ElementInIndexOperation::DELETE,
             default => ElementInIndexOperation::NOTHING,
         };
 
@@ -114,10 +114,10 @@ private function doHandleIndex(
         }
 
         match ($operation) {
-            ElementInIndexOperation::DELETE => $this->deleteElementFromIndex($element, $elasticaIndex, $document),
-            ElementInIndexOperation::NOTHING => null,
             ElementInIndexOperation::INSERT => $this->addElementToIndex($element, $elasticaIndex, $document),
             ElementInIndexOperation::UPDATE => $this->updateElementInIndex($element, $elasticaIndex, $document),
+            ElementInIndexOperation::DELETE => $this->deleteElementFromIndex($element, $elasticaIndex, $document),
+            ElementInIndexOperation::NOTHING => null,
         };
 
         if (!self::$propagationStopped && !$event->isPropagationStopped()) {