Fix return type in getCurrentLinkForSite()

vaersaagod · Mar 24, 2023 · bd5992c · bd5992c
1 parent 9d95574
commit bd5992c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # GeoMate Changelog
 
+## 2.1.1 - 2023-03-24  
+### Fixed
+- Fixed a bug that could result in a PHP exception if a site link ended up being `null`. Fixes #58
+
 ## 2.1.0 - 2022-10-04
 ### Changed  
 - Auto-redirects based on browser language now always work, regardless of GeoMate having access to a geolocation database or not. #53  

diff --git a/composer.json b/composer.json
@@ -1,7 +1,7 @@
 {
     "name": "vaersaagod/geomate",
     "description": "GeoMate is a friend in need for all things geolocation. IP to geo lookup, automatic redirects (based on country, continent, language, etc), site switcher... You name it.",
-    "version": "2.1.0",
+    "version": "2.1.1",
     "type": "craft-plugin",
     "keywords": [
         "craft",

diff --git a/src/helpers/GeoMateHelper.php b/src/helpers/GeoMateHelper.php
@@ -127,7 +127,7 @@ public static function getSiteLinks(): array
         return $r;
     }
 
-    public static function getCurrentLinkForSite(Site $site, bool $elementMatchOnly = false): bool|string
+    public static function getCurrentLinkForSite(Site $site, bool $elementMatchOnly = false): bool|null|string
     {
         // Get the site URL for the found site, this will be the fallback if we're not on an element's url
         $url = $elementMatchOnly ? null : $site->getBaseUrl();