New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add focus and blur methods, focused property #398
Conversation
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed. Comments from Reviewable |
I miss the tabindex property that should have any form control. But after experimenting with it, I don't found a 100% working solution. So let's leave this for a separated PR because other elements also have the same problem. Reviewed 2 of 2 files at r1. Comments from Reviewable |
Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. vaadin-combo-box.html, line 407 at r1 (raw file):
This isn't used test/vaadin-combo-box-properties.html, line 209 at r1 (raw file):
Unneeded variable. Comments from Reviewable |
I too think this should work with tabbing. Here's a prototype proposal that enables tabbing both in Shadow and Shady: https://jsfiddle.net/Saulis/8mj7xzfa/ Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Comments from Reviewable |
Smart solution @Saulis, I added it to my tabindex conclusions here: Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Comments from Reviewable |
87ecbe6
to
2b92a6f
Compare
2b92a6f
to
b9609da
Compare
@Saulis is it ok to add this in a separate PR? Reviewed 2 of 2 files at r2. vaadin-combo-box.html, line 407 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. test/vaadin-combo-box-properties.html, line 209 at r1 (raw file): Previously, tomivirkki (Tomi Virkki) wrote…
Done. Comments from Reviewable |
Yes I'm OK with that, I can add a separate ticket for it. Review status: all files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Comments from Reviewable |
Reviewed 2 of 2 files at r2. Comments from Reviewable |
vaadin/vaadin-combo-box#398 Flow-component: vaadin-combo-box
vaadin/vaadin-combo-box#398 Flow-component: vaadin-combo-box
Fixes #349
This change is