Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style tag needs to live inside the template. Fixes #361 #362

Merged
merged 1 commit into from Dec 20, 2016
Merged

Style tag needs to live inside the template. Fixes #361 #362

merged 1 commit into from Dec 20, 2016

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Dec 20, 2016 •
edited by Saulis

Fixes #361

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2016 •
edited

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@web-padawan
Copy link
Member Author

I signed the CLA.

@limonte
Copy link
Contributor

limonte commented Dec 20, 2016 •
edited

You haven't actually :) Probably it's because you've used two accounts: @web-padawan for creating the PR and another one @s-kulikov for the commit.

@web-padawan
Copy link
Member Author

Thanks @limonte ! Updated this PR.

limonte
limonte approved these changes Dec 20, 2016
View reviewed changes
Copy link
Contributor

@limonte limonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@platosha
Copy link
Contributor

:lgtm:

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

Comments from Reviewable

@platosha platosha merged commit 5ed3dd6 into vaadin:master Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limonte limonte limonte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@web-padawan @CLAassistant @limonte @platosha