Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leaking input styles #361

Closed
web-padawan opened this issue Dec 20, 2016 · 3 comments
Closed

Leaking input styles #361

web-padawan opened this issue Dec 20, 2016 · 3 comments

Comments

@web-padawan
Copy link
Member

Description

The vaadin-combo-box element styles affect globals scope when using bundling.
All my inputs have padding due to the following lines:

    #input {
      box-sizing: border-box;
      padding-right: 28px;
    }
@platosha
Copy link
Contributor

platosha commented Dec 20, 2016

What tools are you using for bundling styles? It’s a local style of <vaadin-combo-box>, I wonder why the tooling does not scope it.

@tomivirkki
Copy link
Member

It's probably due to <style> being defined outside <template> in https://github.com/vaadin/vaadin-combo-box/blob/master/vaadin-combo-box.html

@web-padawan
Copy link
Member Author

I use polymer-build. AFAIK styles shouldn't live outside of templates, this is the thing which may break globals styles somehow. Will send a PR to fix that.

platosha added a commit that referenced this issue Dec 20, 2016
Style tag needs to live inside the template. Fixes #361
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants