fix!: throw when setting value that is not present in key mapper

vaadin-checkbox-flow-parent/vaadin-checkbox-flow/src/main/java/com/vaadin/flow/component/checkbox/CheckboxGroup.java

@@ -352,8 +352,8 @@ private void handleDataChange(DataChangeEvent<T> dataChangeEvent) {
                     item -> Objects.equals(getItemId(item.item), otherItemId))
                     .findFirst().ifPresent(this::updateCheckbox);
         } else {
-            keyMapper.removeAll();
             selectionPreservationHandler.handleDataChange(dataChangeEvent);
+            keyMapper.removeAll();
             rebuild();
         }
     }
@@ -424,6 +424,12 @@ public void setValue(Set<T> value) {
         Objects.requireNonNull(value,
                 "Cannot set a null value to checkbox group. "
                         + "Use the clear-method to reset the component's value to an empty set.");
+
+        if (value.stream().anyMatch(item -> !keyMapper.has(item))) {
+            throw new IllegalArgumentException(
+                    "Value must be one of the items in CheckboxGroup");
+        }
+
         super.setValue(value);
         refreshCheckboxes();
     }

vaadin-checkbox-flow-parent/vaadin-checkbox-flow/src/test/java/com/vaadin/flow/component/checkbox/tests/CheckboxGroupTest.java

@@ -523,8 +523,8 @@ public void withoutSettingIdentifierProvider_setItemWithNullId_shouldSelectCorre
         Assert.assertArrayEquals(new long[] { 2L }, selectedIds);
     }
 
-    @Test
-    public void setIdentifierProviderOnId_setItemWithNullId_shouldFailToSelectExistingItemById() {
+    @Test(expected = IllegalArgumentException.class)
+    public void setIdentifierProviderOnId_setItemWithNullId_throws() {
         CustomItem first = new CustomItem(1L, "First");
         CustomItem second = new CustomItem(2L, "Second");
         CustomItem third = new CustomItem(3L, "Third");
@@ -540,8 +540,6 @@ public void setIdentifierProviderOnId_setItemWithNullId_shouldFailToSelectExisti
 
         checkboxGroup
                 .setValue(Collections.singleton(new CustomItem(null, "First")));
-        Assert.assertNull(checkboxGroup.getSelectedItems().stream().findFirst()
-                .get().getId());
     }
 
     @Test

vaadin-radio-button-flow-parent/vaadin-radio-button-flow/src/main/java/com/vaadin/flow/component/radiobutton/RadioButtonGroup.java

@@ -84,7 +84,7 @@ public class RadioButtonGroup<T>
         HasThemeVariant<RadioGroupVariant>, HasValidationProperties,
         HasValidator<T>, SingleSelect<RadioButtonGroup<T>, T> {
 
-    private final KeyMapper<T> keyMapper = new KeyMapper<>();
+    private final KeyMapper<T> keyMapper = new KeyMapper<>(this::getItemId);
 
     private final AtomicReference<DataProvider<T, ?>> dataProvider = new AtomicReference<>(
             DataProvider.ofItems());
@@ -121,6 +121,9 @@ private static <T> T presentationToModel(
 
     private static <T> String modelToPresentation(
             RadioButtonGroup<T> radioButtonGroup, T model) {
+        if (model == null) {
+            return "";
+        }
         if (!radioButtonGroup.keyMapper.has(model)) {
             return null;
         }
@@ -374,6 +377,11 @@ public ItemLabelGenerator<T> getItemLabelGenerator() {
 
     @Override
     public void setValue(T value) {
+        if (value != null && !keyMapper.has(value)) {
+            throw new IllegalArgumentException(
+                    "Value must be one of the items in RadioButtonGroup");
+        }
+
         super.setValue(value);
         if (value == null) {
             getRadioButtons().forEach(rb -> rb.setChecked(false));

vaadin-radio-button-flow-parent/vaadin-radio-button-flow/src/test/java/com/vaadin/flow/component/radiobutton/RadioButtonGroupTest.java

@@ -422,8 +422,8 @@ public void withoutSettingIdentifierProvider_setItemWithNullId_shouldSelectCorre
                 radioButtonGroup.getValue().getId());
     }
 
-    @Test
-    public void setIdentifierProviderOnId_setItemWithNullId_shouldFailToSelectExistingItemById() {
+    @Test(expected = IllegalArgumentException.class)
+    public void setIdentifierProviderOnId_setItemWithNullId_throws() {
         CustomItem first = new CustomItem(1L, "First");
         CustomItem second = new CustomItem(2L, "Second");
         CustomItem third = new CustomItem(3L, "Third");
@@ -438,7 +438,6 @@ public void setIdentifierProviderOnId_setItemWithNullId_shouldFailToSelectExisti
         listDataView.setIdentifierProvider(CustomItem::getId);
 
         radioButtonGroup.setValue(new CustomItem(null, "First"));
-        Assert.assertNull(radioButtonGroup.getValue().getId());
     }
 
     @Test

vaadin-select-flow-parent/vaadin-select-flow/src/main/java/com/vaadin/flow/component/select/Select.java

@@ -830,6 +830,16 @@ protected boolean valueEquals(T value1, T value2) {
         return getItemId(value1).equals(getItemId(value2));
     }
 
+    @Override
+    public void setValue(T value) {
+        if (value != null && !keyMapper.has(value)) {
+            throw new IllegalArgumentException(
+                    "Value must be one of the items in Select");
+        }
+
+        super.setValue(value);
+    }
+
     private void initConnector() {
         runBeforeClientResponse(ui -> {
             ui.getPage().executeJs(

vaadin-select-flow-parent/vaadin-select-flow/src/test/java/com/vaadin/flow/component/select/SelectTest.java

@@ -772,8 +772,8 @@ public void withoutSettingIdentifierProvider_setItemWithNullId_shouldSelectCorre
         Assert.assertEquals(Long.valueOf(2L), select.getValue().getId());
     }
 
-    @Test
-    public void setIdentifierProviderOnId_setItemWithNullId_shouldFailToSelectExistingItemById() {
+    @Test(expected = IllegalArgumentException.class)
+    public void setIdentifierProviderOnId_setItemWithNullId_throws() {
         CustomItem first = new CustomItem(1L, "First");
         CustomItem second = new CustomItem(2L, "Second");
         CustomItem third = new CustomItem(3L, "Third");
@@ -787,7 +787,6 @@ public void setIdentifierProviderOnId_setItemWithNullId_shouldFailToSelectExisti
         listDataView.setIdentifierProvider(CustomItem::getId);
 
         select.setValue(new CustomItem(null, "First"));
-        Assert.assertNull(select.getValue().getId());
     }
 
     @Test