Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DAR-1104][External] Fix colours mismatch between files on semantic mask export #789

Conversation

AndriiKlymchuk
Copy link
Contributor

Problem

The same semantic mask could be represented by different colors in the files of the same export.

Solution

The root cause of the issue is an assumption that labels in the raster_layer.data.mask_annotation_ids_mapping are the same across different files which is not true. Because of that assumption labels were used as colors ids causing the mismatch.
I changed the logic to have static color ids for all files and convert labels into color ids for every file separately.

Changelog

Fix colours mismatch between files on semantic mask export

Copy link

linear bot commented Mar 15, 2024

Copy link
Contributor

@JBWilkie JBWilkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by comparing output masks of master branch to this one, always had consistent colour mappings on this branch

LGTM!

Copy link
Member

@saurbhc saurbhc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@umbertoDifa umbertoDifa merged commit 423de1b into master Mar 15, 2024
16 checks passed
@AndriiKlymchuk
Copy link
Contributor Author

@umbertoDifa you were to fast. I found one issue during testing. Opening another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants